feat(MultipleLanguages): Delete translations when components are deleted #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffreykwan
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Deleting one component seems to work but deleting multiple components at the same time does not delete all the translations that should be deleted. If a translation save request is made for each component that is deleted, it leads to a race condition since it saves all the translations in each request.
…ting translation changes
|
Good catch. I've changed the service function to handle removing multiple components' translations at at time to prevent overwriting. PTAL |
hirokiterashima
deleted the
multiple-languages-delete-component-translations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Test